Re: pass-through linux ioctl for mfi(4)

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Sun, Sep 16, 2012 at 05:15:44PM +0000, Christos Zoulas wrote:
> In article <20120916152553.GA1275%antioche.eu.org@localhost>,
> Manuel Bouyer  <bouyer%antioche.eu.org@localhost> wrote:
> >-=-=-=-=-=-
> >
> >On Sun, Sep 16, 2012 at 03:23:22PM +0200, Manuel Bouyer wrote:
> >> Hello,
> >> the attached patch adds a pass-through ioctl interface, with the
> >
> >As several of you noctied I forgot (once again) to attach the patch.
> >Here it is.
> 
> As thor mentioned, the commands and arguments need sanity checking.
> For example the malloc'ed len is unchecked and comes from userland.

I'll have a look

> I think that a better way to multiplex the ioctl is to determine
> what device you have from the fd.

I agree, but I don't know how to do this (is there a better way than
hardcoding mfi's major number in compat_linux), can you give details on how
you would do this ?

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--