tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: sysmon_envsys ENVSYS_INDICATOR state change reports

On Sun, 26 Aug 2012, David Holland wrote:

On Sun, Aug 26, 2012 at 12:24:33PM -0700, Paul Goyette wrote:
> >Well, in the case of the BBU it would be better to display good or bad.
> >ABSENT would be misleading, becase what we really want to report
> >is that the BBU is present but bad.
> I'm sure we could come up with dozens of pairs of values, GOOD/BAD,

They won't all be pairs either (e.g., ABSENT/DISABLED/ENABLED). You
want support for enumeration types... I haven't looked at the code at
all, but I'd expect it won't be all that difficult.

For multi-value indicators, we have ENVSYS_INTEGER. Coupled with the ENVSYS_FMONSTCHANGED flag you can get notified whenever the value changes.

The existing code is a total nightmare, and really needs a complete redesign. Until that happens, adding new sensor/notification behaviors is generally quite messy.

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index