Re: Accessing EHCI_USBINTR (Was: CVS commit: src/sys/dev/pci)

[Matt Thomas <matt%3am-software.com@localhost>]

On Jul 19, 2012, at 7:03 PM, Valeriy E. Ushakov wrote:

> On Fri, Jul 20, 2012 at 01:26:19 +0000, Valeriy E. Ushakov wrote:
> 
>> Module Name: src
>> Committed By:        uwe
>> Date:                Fri Jul 20 01:26:19 UTC 2012
>> 
>> Modified Files:
>>      src/sys/dev/pci: ehci_pci.c
>> 
>> Log Message:
>> EHCI_USBINTR is 4 bytes wide, use proper access ops.
>> 
>> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.55 -r1.56 src/sys/dev/pci/ehci_pci.c
> 
> We seem to have some more copy-pasted copies.  Please, can someone
> with the hardware fix and test it?
> 
> $ gid EHCI_USBINTR | grep '2('
> arch/arm/gemini/obio_ehci.c:125:        EOWRITE2(sc, EHCI_USBINTR, 0);
> arch/arm/imx/imxusb.c:189:      EOWRITE2(hsc, EHCI_USBINTR, 0);
> arch/mips/rmi/rmixl_ehci.c:122: EOWRITE2(sc, EHCI_USBINTR, 0);
> arch/mips/atheros/dev/ehci_arbus.c:113: EOWRITE2(sc, EHCI_USBINTR, 0);
> arch/powerpc/booke/dev/pq3ehci.c:141:   EOWRITE2(&sc->sc, EHCI_USBINTR, 0);

these have been done.