tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: add disk size to "struct disk"?

Le 30/04/12 16:43, Matthias Drochner a écrit :

On Sat, 28 Apr 2012 15:55:35 +0200
Jean-Yves Migeon<>  wrote:
do you expect the checks to be performed in
userland, so anyone can be free to have overlaps/overflows, or let
the kernel do the checks and return errors using the size obtained
through disk(9)?

The kernel does already do check, see dev/dkwedge/dk.c:dkwedge_add().
There is clearly the intent to catch overlaps, so some design
decision (not necessary final of course) has been done before.
It did just not have the full effect due to implementation bugs.

Is there something like a design document, to see the big plan?

Not that I know of. Overflowing is clearly bogus IMHO, and should not be allowed.

Overlapping is another matter, labels allow that (it is even required, at least for 'c' and sometimes 'd'). Someone might expect wedges to overlap; like a 'raidframe' RAID1 wedge and a 'ffs' wedge.


Home | Main Index | Thread Index | Old Index