Re: Veriexec "lock_state" misuse

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Elad Efrat <elad%NetBSD.org@localhost> wrote:
> -             if (veriexec_verify(l, handle, "(mmap)", VERIEXEC_INDIRECT,
> -                 NULL)) {
> +             vn_lock(vp, LK_SHARED | LK_RETRY);
> +             error = veriexec_verify(l, handle, "(mmap)", VERIEXEC_INDIRECT, 
> NULL);
> +             VOP_UNLOCK(vp);
> +             if (error) {

The vnode lock should not be acquired/released if veriexec was not used
in the system - it is undesirable overhead.

-- 
Mindaugas