tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: KASSERTMSG fix



On 25.09.2011 20:17, Joerg Sonnenberger wrote:
Just to practical notes:

(1) Please test that lint(1) is not stupid enough to bail out on it.
(2) Kill the !__STDC__ branches. Preferable doing this first.

(1) How do I check that? Run a distribution with MKLINT=yes would be enough?

make subr_prf.ln or so in the kernel build directory. It's just a useful
to know case, not a show stopper (IMO) if lint doesn't support Yet
Another Part Of C99.

It doesn't seem to choke on it. BTW, the KASSERT* macros are already "linted away" in libkern, so I can't see how lint could get affected by them:

...
#ifndef DIAGNOSTIC
#define _DIAGASSERT(a)  (void)0
#ifdef lint
#define KASSERTMSG(e, msg, ...) /* NOTHING */
#define KASSERT(e)              /* NOTHING */
#else /* !lint */
..

So I am planning for the commit + rototill of all KASSERTMSG(...) consumers tomorrow.

--
Jean-Yves Migeon
jeanyves.migeon%free.fr@localhost


Home | Main Index | Thread Index | Old Index