tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: KASSERTMSG fix



On Wed, Sep 07, 2011 at 04:54:05PM +0200, Jean-Yves Migeon wrote:
> The attached patch takes care of this; it does not really "append" the
> msg to the panic string (so it won't be available via panicstr like
> before), but now KASSERTMSG() will print the additional info.

I'm not sure I like the approach. I would prefer to introduce a second
panic() function with explicit file/line number / function argument.
panic() itself could be replaced by a macro calling that new verbose
panic function, maybe under an option.

I think it is time for KASSERTMSG and friends to just adopt C99 variadic
macros with the associated dropping of a pair of (). That involves more
code churn though.

Joerg


Home | Main Index | Thread Index | Old Index