tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: makefs: Seventh Edition(V7) filesystem support.

In article <>,
UCHIYAMA Yasushi  <> wrote:
>I have prepared v7fs support of makefs.
>How about? please review.

        don't check for NULL before calling free.
        option_t should be made to static const (and other fs's)
        fs_specific is void *, so it does not need a cast.
        I don't think that the Calculated size should go to stderr.

The rest looks fine.


Home | Main Index | Thread Index | Old Index