Re: sys/dev/isa/fd.c FDUNIT/FDTYPE

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

> On Wed, May 04, 2011 at 08:50:10PM +0900, Izumi Tsutsui wrote:
> > The problem is that there might be some ports whose MAXPARTITIONS is still 8
> > and such ports can't use type 8.
> 
> Why not? It is not used as a partiton of fd*.
> MAKEDEV is already wrong for those ports, the fd nodes probably should have
> special case handling.

On i386:
---
% ls -l fd1*
brw-r-----  1 root  operator  2,      8 May  7  2003 fd1a
brw-r-----  1 root  operator  2,      9 May  7  2003 fd1b
brw-r-----  1 root  operator  2,     10 May  7  2003 fd1c
brw-r-----  1 root  operator  2,     11 May  7  2003 fd1d
brw-r-----  1 root  operator  2,     12 May  7  2003 fd1e
brw-r-----  1 root  operator  2,     13 May  7  2003 fd1f
brw-r-----  1 root  operator  2,     14 May  7  2003 fd1g
brw-r-----  1 root  operator  2,     15 May  7  2003 fd1h
brw-r-----  1 root  operator  2, 524296 May  7  2003 fd1i
brw-r-----  1 root  operator  2, 524297 May  7  2003 fd1j
brw-r-----  1 root  operator  2, 524298 May  7  2003 fd1k
brw-r-----  1 root  operator  2, 524299 May  7  2003 fd1l
brw-r-----  1 root  operator  2, 524300 May  7  2003 fd1m
brw-r-----  1 root  operator  2, 524301 May  7  2003 fd1n
brw-r-----  1 root  operator  2, 524302 May  7  2003 fd1o
brw-r-----  1 root  operator  2, 524303 May  7  2003 fd1p
---

on amd64:
---
# ls -l fd1*
brw-r-----  1 root  operator  2, 16 May  4 23:31 fd1a
brw-r-----  1 root  operator  2, 17 May  4 23:31 fd1b
brw-r-----  1 root  operator  2, 18 May  4 23:31 fd1c
brw-r-----  1 root  operator  2, 19 May  4 23:31 fd1d
brw-r-----  1 root  operator  2, 20 May  4 23:31 fd1e
brw-r-----  1 root  operator  2, 21 May  4 23:31 fd1f
brw-r-----  1 root  operator  2, 22 May  4 23:31 fd1g
brw-r-----  1 root  operator  2, 23 May  4 23:31 fd1h
brw-r-----  1 root  operator  2, 24 May  4 23:31 fd1i
brw-r-----  1 root  operator  2, 25 May  4 23:31 fd1j
brw-r-----  1 root  operator  2, 26 May  4 23:31 fd1k
brw-r-----  1 root  operator  2, 27 May  4 23:31 fd1l
brw-r-----  1 root  operator  2, 28 May  4 23:31 fd1m
brw-r-----  1 root  operator  2, 29 May  4 23:31 fd1n
brw-r-----  1 root  operator  2, 30 May  4 23:31 fd1o
brw-r-----  1 root  operator  2, 31 May  4 23:31 fd1p
# 
---

So current isa/fd.c can't handle the second drive
on ports where (MAXPARTITIONS != 8 && !__HAVE_OLD_DISKLABEL).

For compatibility with longstanding inconsistent MAKEDEV(8),
it might be better to use DISKUNIT() and DISKPART() for
FDUNIT() and FDTYPE() as other disks, so that we don't have
to have special device minor handling for each MD fd device in
MI MAKEDEV.tmpl script.

---
Izumi Tsutsui