tech-kern archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: ffs fsync patch - block devices and wapbl
On Tue, Apr 19, 2011 at 11:38:00AM +0200, Juergen Hannken-Illjes wrote:
> Block devices have two different properties. First they are device nodes
> having access times etc. and reside on a file system. Second they may have
> a file system mounted on them. With WAPBL it is important to handle these
> properties separately.
>
> Relevant PRs are 41189, 41192, 41977, 42149, 42551, 44377 and 44746 at least.
>
> The attached diff should solve these problems by:
>
> - Replace the ugly sync loop in ffs_full_fsync() with vflushbuf(). This
> loop is a left-over of softdeps and not needed anymore.
>
> - Merge ffs_vfs_fsync() with ffs_full_fsync() so we have only on operation
> whether the request comes from ffs or from other file system via
> VFS_FSYNC().
>
> - Take care which mount to test for WAPBL -- v_mount to update the times and
> wapbl_vptomp() to update the dirty blocks. Never update times when called
> by VFS_FSYNC().
>
>
> Comments or objections?
You mean we don't have to get a devfs to fix this rather serious problem? :-)
Jonathan Kollasch
Home |
Main Index |
Thread Index |
Old Index