tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: WAPBL leaks vnodes on mount error

On Fri, Dec 24, 2010 at 03:33:05AM +0000, David Holland wrote:
> On Wed, Dec 22, 2010 at 12:41:23PM +0000, Michael van Elst wrote:
>  > [...]
>  > There are other places in the WAPBL code (and one in UFS1 dealing with
>  > extended attributes) that get vnodes during a mount operation. While
>  > I haven't seen crashes from this it is likely that such vnodes are
>  > never freed.
>  > There should probably be a general 'free all vnodes from mountpoint'
>  > operation in the mount syscall error path.
> Yes, there should. (This both fixes the general problem in one place,
> and avoids introducing a lot of new uses of vgone to complicate the
> vnode lifecycle mess.)

Unfortunately my change is not even correct. vgone immediately releases
the vnode and apparently it is not necessarily flushed to disk.

As a result a freshly installed system fails to boot in /etc/rc.d/root

                                Michael van Elst
                                "A potential Snark may lurk in every tree."

Home | Main Index | Thread Index | Old Index