Re: locking around LFS_{SET,CLR}_UINO

[Eduardo Horvath <eeh%NetBSD.org@localhost>]

On Tue, 21 Dec 2010, NAKAJIMA Yoshihiro wrote:

> On Sun, 19 Dec 2010 23:41:11 +0000 (UTC),
> Eduardo Horvath <eeh%NetBSD.org@localhost> wrote:
> 
> > Looks reasonable.  You should definitely add a comment somewhere 
> > indicating the uino is protected by the lfs_lock.  Locking protocols must 
> > be documented or they are guaranteed to be broken.  Have you tested it 
> > under load? 
> 
> I've used cp, vi, tar etc. for a week on the filesystem, and it works
> without trouble.  However, I don't know whether my usage is critical
> or not.

At the very least do a kernel build -j4 on it, otherwise you're unlikely 
to hit any interesting deadlocks.

Eduardo