tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: BCM5809S support in bnx(4) and brgphy(4)

On Wed, 1 Dec 2010 20:03:20 +0900, Izumi Tsutsui <> wrote:
Well, no need to use #if BYTE_ORDER if we use uint32_t with
shift ops because word swap is done by hardware.
(that's the reason why we have to swap uint16_t members by #ifdef)

Anyway, no problem to leave them as is to sync FreeBSD/OpenBSD.

Alright, I see.

I would prefer to leave it as is, with this small quirk in the struct. I favor making developer's work easier by having less churn with OpenBSD/FreeBSD drivers.


Jean-Yves Migeon

Home | Main Index | Thread Index | Old Index