tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: misuse of pathnames in rump (and portalfs?)

On Wed Nov 24 2010 at 18:12:00 +0000, David Holland wrote:
>  > As for etfs, as you might be able to see from the code, it's only used
>  > for root vnode lookups.  I cannot think of a reason why we cannot define
>  > the key to start with exactly one leading '/'.  Some in-tree users may
>  > not follow that rule now, but they should be quite trivial to locate
>  > with grep.  That should make it work properly with your finally-nonbroken
>  > namei and also take care of all symlink/.. concerns you might have.
> I think it makes more sense for doregister to check for at least one
> leading '/' and remove the leading slashes before storing the key.
> Then the key will match the name passed by lookup; otherwise the
> leading slash won't be there and it won't match. (What I suggested
> last night is broken because it doesn't do this.)

Ah, yea, the leading slashes will be stripped for lookup, so we can't
get an exact match for those anyway.

So, let's define it as "string beginning with /, leading /'s collapsed
to 1".

> All users I can find pass an absolute path.

ok, good

Home | Main Index | Thread Index | Old Index