Re: memory leak in USB stack

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Wed, Jan 13, 2010 at 12:19:28PM +0100, Manuel Bouyer wrote:
> On Tue, Jan 12, 2010 at 09:32:50PM +0100, Matthias Drochner wrote:
> > 
> > bouyer%antioche.eu.org@localhost said:
> > > The attached patch fixes this by freeing the xfer in
> > > [eou]hci_device_intr_abort() and [eou]hci_root_intr_abort() when the
> > > xfer to be aborted is the pipe's intrxfer.
> > 
> > Just for symmetry - can't this be done in usbd_abort_pipe(),
> > preferrably outside the splusb()?
> 
> Are we sure nothing will change pipe->intrxfer under us outside of splusb ?
> If so the attached patch should be safe, but I find it even uglier than the
> previous one ..

Anyway, I commited this version of the fix.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--