tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: brk(3)/break(2) does not fail for very high adresses



On Mon, Nov 23, 2009 at 05:32:09PM +0100, Nicolas Joly wrote:
> On Mon, Nov 23, 2009 at 05:25:01PM +0100, Joerg Sonnenberger wrote:
> > On Mon, Nov 23, 2009 at 05:10:36PM +0100, Nicolas Joly wrote:
> > > Is the attached patch ok ? It make break(2) fail, when the rounded
> > > adress wrap.
> > 
> > Why not modify the existing check to do (new == 0 || new > old)?
> 
> It could fail early without mutex enter/exit calls.

Yeah, but I don't know if optimising for the error case is really an
improvement.

Joerg


Home | Main Index | Thread Index | Old Index