Re: locking patches for ufs_rename

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Wed Sep 30 2009 at 13:59:51 +0000, David Holland wrote:
> On Mon, Sep 28, 2009 at 04:43:16PM +0200, Manuel Bouyer wrote:
>  > On Mon, Sep 28, 2009 at 04:27:12PM +0200, Manuel Bouyer wrote:
>  > > I found 2 problems that I send to david in private mail.
>  > > I did a backport of these patches to netbsd-5. Running a rsync+cvs update
>  > > on a dual-CPU system, I got:
>  > 
>  > I got another one, with more usefull info from ddb:
>  > [snip]
> 
> rmind says the problem is that tvp (aka tochild_vnode) comes in locked
> if it's not null, and I misread vnode_if.src and thought it wasn't.
> 
> So unlocking that up top should solve this problem. (I thought I'd
> tested this case but apparently I didn't.)
> 
> I got an extra pile of crap dumped on me and consequently don't have
> time to look at it in any detail for the rest of the week. :(

Did any of these kind of changes make it into cvs already?  I got a report
offline about a panic in -current tmpfs_rename where tvp was supplied
but wasn't locked (the IMPLIES KASSERT at the top of the routine).