[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Support for multi-position electro-mechanical keylocks
On Sun, Aug 2, 2009 at 5:54 AM, Marc Balmer<marc%msys.ch@localhost> wrote:
The attached diff, which is also online at
http://www.netbsd.org/~mbalmer/diffs/keylock_03.diff, adds the
+int (*keylock_pos_cb)(void *) = NULL;
+void *keylock_pos_cb_arg = NULL;
I'm not a big fan of such publicly, globally accessible callback.
Especially in a security context. Moreover, if it is not intended to
be accessed out of the file, make them static.
Right. I just defined them as statics
Main Index |
Thread Index |