tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Implement mode_select for atapi tape drives

On Sat, 8 Aug 2009, David Young wrote:

Basically, this whole routine was copied almost verbatim from the
equivalent code in sys/dev/scsipi/st_scsi.c which also calculates the
number of bytes to clear.  Since it worked, I never looked any further.

Why haven't you extracted the code from sys/dev/atapi/ and from
sys/dev/scsipi/ for reuse in both places?  Sounds like it will save you
some trouble

That would be part of a larger clean-up activity, I think.

|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:      |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul at   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index