tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Fixing settime1() to reject invalid struct timespec ?



hi,

> On Mon, Jul 27, 2009 at 03:26:25PM +0200, Joerg Sonnenberger wrote:
>> On Mon, Jul 27, 2009 at 02:37:29PM +0200, Nicolas Joly wrote:
>> > To solve this, we can: (a) use an ugly __UNCONST() when calling
>> > itimespecfix(), or (b) drop the const qualifier from
>> > clock_settime1()/settime1() ...
>> 
>> (c) Normalise into a new variable.
> 
> That's even better ;-) It kills the __UNCONST from kauth call.
> 
> Here follow the corresponding patch.

(d) split itimespecfix into two functions.

the non-const part of itimespecfix doesn't seem appropriate for
an absolute time, which settime1 is for.

YAMAMOTO Takashi

> 
> -- 
> Nicolas Joly
> 
> Biological Software and Databanks.
> Institut Pasteur, Paris.


Home | Main Index | Thread Index | Old Index