[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: GPIO revisited
One more comment...
+int gpio_pinbyname(struct gpio_softc *, char *gp_name);
+/* Old API version */
+int gpio_ioctl_oapi(struct gpio_softc *, u_long cmd, void *data,
+ int pinset);
KNF: no variables names in the declaration.
Also, any reason why these are not static?
While it certainly can make sense to declare functions static in some
userland programs for the sole reason to include a command in a
crunched binary, it does not make sense in kernel code; much to the
contrary, it makes debugging harder.
Main Index |
Thread Index |