Re: A small cgd(4) diff

[Adam Hamsik <haaaad%gmail.com@localhost>]

On Jul,Friday 10 2009, at 4:51 PM, Arnaud Lacombe wrote:

> Hi Jukka,
>
> On Fri, Jul 10, 2009 at 6:24 AM, Jukka Ruohonen<jruohonen%iki.fi@localhost>  
> wrote:
> > > > --- src/sys/dev/cgd.c   5 Jun 2009 19:21:02 -0000       1.58
> > > > +++ src/sys/dev/cgd.c   10 Jul 2009 09:27:10 -0000
> > > > @@ -165,9 +165,8 @@ cgdsoftc_init(struct cgd_softc *cs, int
> > > >  {
> > > >        char    sbuf[DK_XNAME_SIZE];
> > > >
> > > > -       memset(cs, 0x0, sizeof(*cs));
> > >
> > > This memset seems reasonable to me, why have you removed it ?
> >
> > I thought that zeroing the whole buffer with M_ZERO would yield the  
> > same
> > result.
> Then pedantically, it belongs to another changeset than "convert to
> mutex(9) from lock(9)" :-)

It should be probably good to convert malloc(9) to kmem_zalloc(9) in  
that second change then.

Regards

Adam.