tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: smbfs umount kernel panic fixes for review

On Wed, Jul 01, 2009 at 08:23:23PM +0300, Antti Kantee wrote:
> On Wed Jul 01 2009 at 19:13:40 +0200, Nicolas Joly wrote:
> > > If the root vnode being unconditionally destroyed is in fact the problem,
> > > the solution is to make VFS_ROOT() do the right thing.
> > 
> > Does removing the root vnode, while currently in use do make sense ?
> > At least `struct smbnode' refers to it with its n_parent member.
> No.  But vflush() will DTRT unless there are weird extra references
> floating around.  In general the "take extra reference to root vnode"
> is the wrong thing to do.

I'll try to investigate. For now, if i remove the extra root
reference, it crash when trying to iterate all the smbnodes up to the
root one which is gone ...

> But like I said, I didn't look at the code, so I don't know how much
> work properly fixing it is vs. just fixing the panic with hacks.  And I
> don't really care so no objection to your patch ;)


Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.

Home | Main Index | Thread Index | Old Index