tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: ne2000 with 8bit bus width



On Tuesday 05 May 2009 10:00:08 NONAKA Kimihiro wrote:
> Hi,
>
> >> > - It looks now ne2000_detect() also checks if chip is 16 bit DMA
> >> > capable. If so, isn't it better to use the result of ne2000_detect()
> >> > to set sc_useworddma, rather than setting it in backends?
> >>
> >> ne2000_softc is not passed to the ne2000_detect() function.
> >
> > We can change ne2000_detect() appropriately,
> > but your newer patch seems okay.
>
> Because ne2000_detect() function is used by driver's match function,
> softc data cannot be passed to ne2000_detect() function.

Nonaka Kimihiro: While you are about touching ne2k driver,
can you also do the device_t/softc split and implement
suspend/resume, please ?

Christoph


Home | Main Index | Thread Index | Old Index