Re: [PATCH] invalidate pointers right after pool_put()

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Apr 28, 2009 at 02:35:03PM +0100, Mindaugas Rasiukevicius wrote:
> Christoph Egger <Christoph_Egger%gmx.de@localhost> wrote:
> > attached patch invalidates pointers right after pool_put().
> > I'm running a machine with this patch for several month
> > w/o any problems.
> > 
> > Is it ok to commit?
> 
> The kmem(9) and pool(9) subsystems already perform use-after-free checking
> in debug/diagnostic kernels. I do not think there is a benefit in such patch,

especially as in several place it zero out the local pointer but not
the one in the referencing structure or calling function, which is
more likely to perform a use after free than a local variable.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--