tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Common chmod and chown routines

On Mon, Apr 20, 2009 at 9:56 PM, Mindaugas Rasiukevicius
<> wrote:
> Elad Efrat <> wrote:
>> > Can this and other "goto out" calls (including common_chown() function) be
>> > replaced with returns? There is no point to use them here.
>> Why?
> Because there is no point (no common end-point code, therefore it is
> confusing and just sticks additional instructions).

I actually prefer this style, even if there is no point, and I am going
to cast a doubt over any claims of measurable performance impact. :)

But I'll tell you what: I won't mind if anyone changes it, now that
it's in tree...


Home | Main Index | Thread Index | Old Index