tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Wrong notify handler in acpitz(4)?



Hi.

With some ACPICA debugging I see:

...
Dispatching Notify on [TZ1_] Node 0xffff800003ff51b0 Value 0x81 (**Device
Specific**)
No notify handler for Notify (TZ1_, 81) node 0xffff800003ff51b0
Dispatching Notify on [TZ2_] Node 0xffff800003ff6bb0 Value 0x81 (**Device
Specific**)
No notify handler for Notify (TZ2_, 81) node 0xffff800003ff6bb0
...

So I think this should be:

Index: acpi_tz.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_tz.c,v
retrieving revision 1.39
diff -u -p -r1.39 acpi_tz.c
--- acpi_tz.c   9 Nov 2008 13:54:06 -0000       1.39
+++ acpi_tz.c   19 Apr 2009 20:15:39 -0000
@@ -187,9 +187,9 @@ acpitz_attach(device_t parent, device_t 
        acpitz_get_status(self);
 
        rv = AcpiInstallNotifyHandler(sc->sc_devnode->ad_handle,
-           ACPI_SYSTEM_NOTIFY, acpitz_notify_handler, self);
+           ACPI_DEVICE_NOTIFY, acpitz_notify_handler, self);
        if (ACPI_FAILURE(rv)) {
-               aprint_error(": unable to install SYSTEM NOTIFY handler: %s\n",
+               aprint_error(": unable to install notify handler: %s\n",
                    AcpiFormatException(rv));
                return;
        }


Which solves the problem on this particular laptop.

- Jukka.


Home | Main Index | Thread Index | Old Index