Re: the __ namespace in the kernel

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Apr 02, 2009 at 07:47:25PM +1100, matthew green wrote:
> 
>    On Thu, Apr 02, 2009 at 09:44:56AM +1100, matthew green wrote:
>    > 
>    >    >__wdccommand_done
>    >    >__wdccommand_done_end
>    >    >__wdccommand_intr
>    >    >__wdccommand_kill_xfer
>    >    >__wdccommand_start
>    >    >__wdcerror
>    >    >__wdcwait
>    >    >__wdcwait_reset
>    >    >__wdstart
>    > 
>    > these seem all wdc driver private, i don't see why they can't
>    > just all be renamed.
>    
>    It is; that's why I did prefix them with __ in the first place. They're
>    all declared static, why would it cause namespace issues ?
> 
> 
> is there any particular reason you want driver private to use __?

_ is fine with me, it's just it helps to see what is private and what is
not (though now they're static this is less of a reason)

> why can't you simply remove them all, if they are static?

Some of them are backend functions for a function with the same name
without __ (e.g. wdcwait() vs __wdcwait()).

> 
> the issue is about "all" symbols with __ start.

That's what I don't understand. but whatever ...

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--