tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: clockctl clock_settime bug



   > !          if (args->tp) {
   > !                  error = copyin(args->tp, &ts, sizeof ts);
   > !                  if (error)
   > !                          return (error);
   > !                  error = clock_settime1(l->l_proc, args->clock_id,
   > !                              &ts, false);
   > !          }
   
   We shouldn't do the `if (args->tp)' test.  If NULL is passed, it is an
   error isn't it?  Just let the copyin to DTRT.


probably.  i was copying style from above 8-/


.mrg.


Home | Main Index | Thread Index | Old Index