Re: Using wsdisplay from the Xserver

[Michael <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Jan 24, 2009, at 5:30 PM, der Mouse wrote:

> > > PCI_IOC_CFGREAD
> > That's an interface which is already there and used by X.
>
> That's the problem.  X has no business dealing with the level of PCI
> config registers; that's for the PCI attachment code for the graphics
> hardware to deal with.  See also below.

Eh?

> > Why reinvent the wheel?
>
> Because the one that's there is the wrong wheel.  The X server should
> be telling the driver "give me the $FOO registers", not mucking about
> with PCI config itself.

That's exactly what this ioctl() is doing.

>  What if the attachment the chip is behind isn't PCI?  Userland  
> shouldn't care about that any more than it cares about whether a  
> file is on a bha-attached Seagate drive or a Firewire-attached  
> Western Digital drive.

Feel free to rewrite the Xserver and all its drivers.

> > Accessing a graphics chip's config space is ok in my book and indeed
> > necessary.
>
> The _graphics chip_'s config space, yes.

Again - that's all it gets.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBSXufpMpnzkX8Yg2nAQKOmwgAlVXiTBFd7w5vZ7iGub8ozUzvvoBr2tVm
6ZolF8OXNC7jKw/NYpnWszp0Q7jioxNqSJe158yi9rqbd7QIIiE6gawh8zec/sOm
n8qvqWxSnTCvDNZH3oY25AEthXS46EHAtUgFkdjT50LqkchoBZ6EceHOZ5nr76+t
5SzW4EIQqUK4YnpMP+Cw7edKfFBuEJywmLSnwzDd0SVmOFJGfyiRhenMMgmfNQ2U
wGCtG34wzEaz8zrYLvAopK3fROEmX1hKaiwMrP95YNzHlTF585a0YiP0uURVu3ps
tgVry9+XGB6n4sV9Cmyb9EVo7pof/Ho+4lQq2Nix7xWz563QGv8sGw==
=XpEi
-----END PGP SIGNATURE-----