Re: dubious ADDUPROF macro definition

[christos%astron.com@localhost (Christos Zoulas)]

In article <20081218012526.GA53846%medusa.sis.pasteur.fr@localhost>,
Nicolas Joly  <njoly%pasteur.fr@localhost> wrote:
>-=-=-=-=-=-
>
>
>Hi,
>
>The ADDUPROF macro definition looks dubious to me. In then following
>code (copied from sys/sys/resourcevar.h) the argument `p' is unused,
>and this macro was converted to use a LWP instead ...
>
>/* add user profiling from AST XXXSMP */
>#define ADDUPROF(p)                                                     \
>        do {                                                            \
>                struct proc *_p = l->l_proc;                            \
>                addupc_task(l,                                          \
>                    (_p)->p_stats->p_prof.pr_addr,                      \
>                    (_p)->p_stats->p_prof.pr_ticks);                    \
>                (_p)->p_stats->p_prof.pr_ticks = 0;                     \
>        } while (/* CONSTCOND */ 0)
>
>How about the attached patches, which fix the macro definition and
>convert some remaining archs (arm, luna68k, powerpc, sh3) still using
>a proc argument.

Please do!

christos