Re: ffs_balloc_ufs1 error handling

[Andrew Doran <ad%netbsd.org@localhost>]

On Sun, Dec 07, 2008 at 09:05:20PM +0100, Joerg Sonnenberger wrote:

> from my understand of the code and the history of ffs_balloc_ufs1,
> the first if after fail: is meant to flush the vnode content to disk to
> break up dependencies. From FreeBSD's history, this is the cheap
> approach to handle erroring out for softdep filesystems when they become
> full.

1. It doesn't work for softdep, it hangs.

2. It does what the comment above it says.

3. It also attempts to invalidate blocks associated with the vnode.
   It is not clear to me at a glance if that works as intended.

> Does anyone object the attached patch to conditionalize this logic on
> softdep?

Yes, it will corrupt full file systems if they are not using softdep.

Andrew