Re: ffs_balloc_ufs1 error handling

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sun, Dec 07, 2008 at 11:11:09PM +0200, Antti Kantee wrote:
> > 
> > Did you read my mail at all? It wasn't done at all before the
> > introduction of softdep. From reading the code it only forces a lot of
> > serialisation and manual pruning of the buffer cache for !softdep.
> 
> I read it, but I didn't realize issues potentially fixed by softdep can
> be broken without any rationale quoting that the fix came with softdep.

http://svnweb.freebsd.org/viewvc/base?view=revision&revision=55799
Which part of "erroring out for softdep filesystems" is not about
softdep.

> > > One situation where block allocation can fail even without the file
> > > system being full is with B_CONTIG.  Does that case still work?
> > 
> > Is there any way to test B_CONTIG allocations? This looks like dead code
> > right now...
> 
> flags & B_CONTIG.  But an error is an error...

I don't see why this should be any different than running out of space
globally.

Joerg