Re: ACPI Issues on Lifebook P7120 (with fixes)

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

On Fri, 5 Dec 2008, Gr�goire Sutre wrote:
> For people interested in using this, please follow the attached INSTALL
> file and give feedback :-)
>
> Comments, suggestions, corrections, flames: all welcome :-)

Looks very good to me. acpi_display.c did not build for me, though.
I have attached the diff which fixes the build for me.

Christoph

--- acpi_display.c.orig 2008-12-05 18:46:42.000000000 +0100
+++ acpi_display.c      2008-12-05 18:46:25.000000000 +0100
@@ -141,6 +141,8 @@ acpidisplay_attach(device_t parent, devi
 #ifdef ACPI_DISPLAY_DEBUG
        for (i = 0 ; i < sc->sc_noutdev ; i++) {
                ACPI_BUFFER buf;
+               ACPI_DEVICE_INFO *info;
+               char *charp;
 
                buf.Pointer = NULL;
                buf.Length = ACPI_ALLOCATE_BUFFER;
@@ -151,8 +153,8 @@ acpidisplay_attach(device_t parent, devi
                        continue;
                }
 
-               ACPI_DEVICE_INFO *info = buf.Pointer; /* shall be non NULL */
-               char *charp = (char *) &(info->Name);
+               info = buf.Pointer; /* shall be non NULL */
+               charp = (char *) &(info->Name);
                aprint_debug_dev(self,
                    "outdev %d: { %s: %c%c%c%c, %s: 0x%x, %s: 0x%llx }\n", i,
                    "name", charp[0], charp[1], charp[2], charp[3],
@@ -232,7 +234,8 @@ acpidisplay_register_output_device(ACPI_
 
        if (hdl == NULL) {
                aprint_error_dev(sc->sc_dev,
-                   "failed to find output device : %llx\n", attr);
+                   "failed to find output device : %"PRIx64"\n",
+                   (uint64_t)attr);
                /* Continue foreach iteration in enumerate_output_devices */
                return AE_OK;
        }