tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wsdisplay_kbdholdscreen() said:
> +       if (!scr)
> +               return;

This is OK, because the "hold screen" comes at spltty
while an asynchronous VT switch (involving X server
synchronisation) might be in progress. That combination
of keypresses is unlikely to be done by intelligent users,
thus noone noticed so far.
Locking around VT switches is hairy because one wants
it to work in DDB after a panic. Perhaps some blackhole
pseudo-screen could be used to catch events while no
VT is active.

> Does anyone know of a good reason I should not commit this, and
> ask for pull-ups?

Other code in wscons does the same. It should be pulled up.

best regards

Forschungszentrum Juelich GmbH
52425 Juelich

Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr. Harald Bolt,
Dr. Sebastian M. Schmidt

Home | Main Index | Thread Index | Old Index