tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Uninitialized var in altq_subr.c

At 12:47 Uhr +0300 27.10.2008, Andy Shevchenko wrote:
On Mon, Oct 27, 2008 at 12:16 PM, Hauke Fath <> 
 1.16         (peter    12-Oct-06): u_int64_t
 1.16         (peter    12-Oct-06): read_machclk(void)
 1.1          (thorpej  14-Dec-00): {
 1.16         (peter    12-Oct-06):      u_int64_t val;
 1.16         (peter    12-Oct-06):
 1.16         (peter    12-Oct-06):      if (machclk_usepcc) {
 1.25         (ad       10-May-08): #ifdef __HAVE_CPU_COUNTER
 1.25         (ad       10-May-08):              return cpu_counter();

  return <XXX>;

This solution more clear as I think.

 1.16         (peter    12-Oct-06): #endif

And what would <xxx> be?  ;)

I am not too fond of functions with umpteen return points; but that's a matter of taste, I guess.


     The ASCII Ribbon Campaign                    Hauke Fath
()     No HTML/RTF in email            Institut für Nachrichtentechnik
/\     No Word docs in email                     TU Darmstadt
     Respect for open standards              Ruf +49-6151-16-3281

Home | Main Index | Thread Index | Old Index