Re: rtsock.c:rt_msg2() appears to be overwriting buffers it does not own

[Brett Lymn <blymn%baesystems.com.au@localhost>]

On Sun, Oct 26, 2008 at 09:47:24AM +0000, Andrew Doran wrote:
> On Fri, Oct 24, 2008 at 02:43:12PM +0000, Christos Zoulas wrote:
> 
> > Are you sure it is the routing code? It could be the sysctl_iflist() one 
> > too.
> > Can you put some more debugging code to verify? I am saying that because
> > the sysctl_rtable() is protected with splsoftnet(), but the sysctl_iflist()
> > is not, and perhaps it should.
> 
> I missed that one, it should be taking softnet_lock (not splsoftnet).
> 

I guess you are talking about sysctl_rtable() here?  I cannot see how
this would affect route_output().  The only consumer of route_output()
I can see is an indirect call in raw_usrreq.c:raw_usrreq(), should we
be taking softnet_lock there too?


-- 
Brett Lymn
"Warning:
The information contained in this email and any attached files is
confidential to BAE Systems Australia. If you are not the intended
recipient, any use, disclosure or copying of this email or any
attachments is expressly prohibited.  If you have received this email
in error, please notify us immediately. VIRUS: Every care has been
taken to ensure this email and its attachments are virus free,
however, any loss or damage incurred in using this email is not the
sender's responsibility.  It is your responsibility to ensure virus
checks are completed before installing any data sent in this email to
your computer."