Re: Unused SI_LWP si_code definition ?

[Nicolas Joly <njoly%pasteur.fr@localhost>]

On Thu, Oct 16, 2008 at 08:49:03AM +0000, Andrew Doran wrote:
> On Wed, Oct 15, 2008 at 05:42:30PM +0200, Nicolas Joly wrote:
> 
> > While looking into existing si_code values, i discovered SI_LWP
> > definition (src/sys/sys/siginfo.h). According to the corresponding
> > comment it should be set by _lwp_kill(2), but it SI_USER is set
> > instead ... So this value is currently unused.
> 
> It should have been SI_LWP. I have changed it.

Thanks.

> > For compat linux NPTL emulation, i do need this functionality, where 2
> > syscalls tkill and tgkill set up si_code to SI_TKILL. This value is
> > needed by a handler in libpthread to switch a bit, allowing threads to
> > be properly cancelled.
> > 
> > Is it ok to use it for compat linux ? If yes, don't we need to update
> > _lwp_kill(2) accordingly ?
> 
> Do you want to change something outside of the Linux compat code? I'm
> not sure what you're proposing to do.

Except eventually adding SI_LWP knowledge for kdump(1); i don't intent
to modify anything outside Linux compat.

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.