Re: Fix for PR kern/38273

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Sep 11, 2008 at 11:57:03AM +0100, Matthias Scheler wrote:
> 
>       Hello,
> 
> Juan RP suggested a simple fix for PR kern/38273:
> 
>  Index: ld.c
>  ===================================================================
>  RCS file: /cvsroot/src/sys/dev/ld.c,v
>  retrieving revision 1.63
>  diff -b -u -p -r1.63 ld.c
>  --- ld.c        9 Sep 2008 12:45:39 -0000       1.63
>  +++ ld.c        10 Sep 2008 16:06:25 -0000
>  @@ -99,7 +99,7 @@ ldattach(struct ld_softc *sc)
>   {
>          char tbuf[9];
> 
>   
>  -       mutex_init(&sc->sc_mutex, MUTEX_DEFAULT, IPL_VM);
>  +       mutex_init(&sc->sc_mutex, MUTEX_DEFAULT, IPL_NONE);
> 
>   
>          if ((sc->sc_flags & LDF_ENABLED) == 0) {
>                  aprint_normal_dev(sc->sc_dv, "disabled\n");
> 
> Considering that other pseudo drivers (e.g. raid(4)) use IPL_NONE, too,
> this seems to be reasonabl to me.

raid(4) has it own thread; while ld(4) can run in interrupt context.
So I'm not sure IPL_NONE would be appropriate here.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--