tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Nvidia MCP67 SATA controller



On Fri, Jun 27, 2008 at 11:55:00AM +0200, Dieter Baron wrote:
> hi,
> 
> attached is a cleaned up version of my previous patch to make MCP65
> and MCP67 SATA controllers work: Make ahcisata match, even if the
> controller is not in AHCI mode; increase the delay after a channel
> reset to 500ms (from 100ms).  I've also restructured the match
> function to only map the registers if we actually check which mode the
> controller is in.

I think this part of the patch is wrong. We should not match if we
can't map the AHCI registers, as it's not going to work anyway.
The BIOS may have configured it in pciide-compatible mode, which which
case the AHCI registers may not be mappable.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--


Home | Main Index | Thread Index | Old Index