tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: semctl(2) SETVAL/SETALL does not validate the semaphore value



On Mon, May 05, 2008 at 02:00:54PM +0100, Mindaugas Rasiukevicius wrote:
> Nicolas Joly <njoly%pasteur.fr@localhost> wrote:
> > +                   if ((unsigned int)semval > seminfo.semvmx) {
> > +                           error = ERANGE;
> > +                           break;
> > +                   semaptr->_sem_base[i].semval = semval;
> > +                   }
> 
> I think you wanted bracket after the "break".

Right, fixed.

> In general looks fine.

Thanks.

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.


Home | Main Index | Thread Index | Old Index