Re: Request for testers - socket locking diff

[Iain Hibbert <plunky%rya-online.net@localhost>]

On Tue, 22 Apr 2008, Andrew Doran wrote:

> Latest version of the patch, against -current today:
>
> http://www.netbsd.org/~ad/socklock-2008042201.diff

Sorry was unable to boot a -current kernel for a couple of weeks (acpi
issue) but will test the bluetooth as far as I'm able soon (visually it
looks ok)

> - Make protocol entry points take kernel_lock, kill the inline wrappers.

I like that better, it would be intended that eventually locking is pushed
right down to individual connections?

> - Replace tcp callout_invoking/callout_ack stuff with callout_halt.
>   The invoking/ack stuff doesn't work properly on MP systems.

got too many arguments to callout_halt, did you miss a file in the diff?

> I think this is nearly ready to go, aside from more testing.

I think you need the below patch (GENERIC kernel does not include ISO)?

iain

--- netiso/clnp_timer.c.orig    2008-04-23 07:18:34.000000000 +0100
+++ netiso/clnp_timer.c 2008-04-23 07:18:17.000000000 +0100
@@ -181,6 +181,7 @@

        mutex_enter(softnet_lock);
        KERNEL_LOCK(1, NULL);
+       cfh = clnp_frags;
        while (cfh != NULL)
                cfh = clnp_freefrags(cfh);
        KERNEL_UNLOCK_ONE(NULL);