tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: physical address space management

On Fri, Mar 28, 2008 at 11:59:54PM +0100, Christoph Egger wrote:
 > >Here is the start of an API:
 > enums are bad in an API. Not the type, but its size. It is defined to be
 > the smallest possible integer to hold the largest value.
 > All enums below are sizeof(char). Whenever a value > 0xff is added, you
 > change the ABI.

That doesn't matter much for in-kernel APIs. (Although sometime we may
want to try to maintain some stable LKM ABIs, this probably wouldn't
appear in them. Or so I'd think.)

I've never liked using enums for bitwise flags, though.

David A. Holland

Home | Main Index | Thread Index | Old Index