tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: compat linux/linux32 uid16 functions cleanup+fixes

On Fri, Jan 04, 2008 at 06:20:57PM +0000, Christos Zoulas wrote:
> In article <>,
> Nicolas Joly  <> wrote:
> >
> >While performing some regressions tests under compat linux/linux32, i
> >noticed that some uid16 functions were failing ... I started fixing
> >them; and while here, made some other cleanups :
> ><URL:>
> >
> >Comments ?
> Looks fine to me. Perhaps though we want to call the types linux_{u,g}id16_t?

Currently linux_uid_t is used outside uid16 code (struct siginfo,
stat{,64}, ...), and then need to be defined for all arches. But only
3 of them define it as a 16bit type (arm, i386 and m68k), all others
use 32bit values (alpha, amd64, mips and powerpc).

What about defining linux_{u,g}id16_t in common/linux_types.h, to be
used by uid16 functions, and leave linux_{u,g}id_t alone for now ?

Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.

Home | Main Index | Thread Index | Old Index