Queue(3), please.

-- thorpej@iPhone

On Oct 28, 2007, at 6:16 AM, Iain Hibbert <plunky@rya-online.net> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Tue, 23 Oct 2007, Jason Thorpe wrote:
>
>> The last remaining uses of insque / remque in the kernel are:
>>
>> C symbol: insque
>>
>> File             Function       Line
>> 0 coda_namecache.c <global>        96 #ifndef insque
>
> Coda is much cleaner than netiso, and its not too difficult to tidy  
> that
> away. There are two ways through it and I'm not sure which is better.
>
> a) If we own that code and want to use queue(3) macros, then  
> diff.queue
> attached does handle that. There is not an exact match between queue 
> (3)
> and the macros that were being used and the original macros were not a
> complete abstraction, so I've just removed them and replaced with the
> queue(3) macros in plain view.
>
> b) If the coda project owns that code and it would be difficult to
> maintain differences, then diff.insque attached removes the  
> dependency by
> giving coda_namecache a private copy of insque/remque and changing  
> nothing
> else.
>
> I notice that FreeBSD uses the same kernel code as us, and could no  
> doubt
> update the same way (they have an open PR to do the second method  
> though
> the patch supplied is much more invasive). Linux has different, so  
> maybe
> the coda project does not have a great claim on it. I prefer the  
> queue(3)
> method, but offer both for comment.
>
> I don't use coda and only have one computer, so testing is needed..
>
> iain
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (NetBSD)
>
> iQEVAwUBRySLrvFJxoMWDXVDAQIAjAgAm1ugd5OU2DH8tRwvCFQrp/HFzeNi9BZy
> XBjIV0UWH+TNeruxv+P/SE5AlmdOmzklRflxvaPuE+seRvYlTpeC4xfnDUABu3iL
> O6v4xY+PDl906lzVN9bYpdYVxWbqdp1wZPV9wiymatio5h42jKfcbXXCsIooMDmj
> 7GOq73++PWncfxdXyfpk7AUMrbKEW7sS7gWsPH7tEaGm/yEW5BXHpOnqYc5CVMGD
> N9U7Xfc28dYhzSMhMmSrJGEKjJY5cKikWJxni1oaSNIA1J6DCy6+nRXnxsid20ST
> 3ma9BLGTLhkXLxr/To5pFolE2FNmlfzhuJOPY6jsEi17Ugqe53iG5g==
> =IFwZ
> -----END PGP SIGNATURE-----
> <diff.queue>
> <diff.insque>