Subject: Re: Last remaining insque / remque uses
To: Iain Hibbert <firstname.lastname@example.org>
From: Jason Thorpe <email@example.com>
Date: 10/28/2007 09:00:06
On Oct 28, 2007, at 6:16 AM, Iain Hibbert <firstname.lastname@example.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On Tue, 23 Oct 2007, Jason Thorpe wrote:
>> The last remaining uses of insque / remque in the kernel are:
>> C symbol: insque
>> File Function Line
>> 0 coda_namecache.c <global> 96 #ifndef insque
> Coda is much cleaner than netiso, and its not too difficult to tidy
> away. There are two ways through it and I'm not sure which is better.
> a) If we own that code and want to use queue(3) macros, then
> attached does handle that. There is not an exact match between queue
> and the macros that were being used and the original macros were not a
> complete abstraction, so I've just removed them and replaced with the
> queue(3) macros in plain view.
> b) If the coda project owns that code and it would be difficult to
> maintain differences, then diff.insque attached removes the
> dependency by
> giving coda_namecache a private copy of insque/remque and changing
> I notice that FreeBSD uses the same kernel code as us, and could no
> update the same way (they have an open PR to do the second method
> the patch supplied is much more invasive). Linux has different, so
> the coda project does not have a great claim on it. I prefer the
> method, but offer both for comment.
> I don't use coda and only have one computer, so testing is needed..
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (NetBSD)
> -----END PGP SIGNATURE-----