Subject: Re: Last remaining insque / remque uses
To: Iain Hibbert <plunky@rya-online.net>
From: Matt Thomas <matt@3am-software.com>
List: tech-kern
Date: 10/24/2007 13:27:38
On Oct 24, 2007, at 11:52 AM, Iain Hibbert wrote:


> @@ -119,7 +120,7 @@
>  	(void) eonattach();
>  }
>
> -struct eon_llinfo eon_llinfo;
> +LIST_HEAD(eon_llhead, eon_llinfo) eon_llhead;
>  #define PROBE_OK 0;
>

Use static initializers instead of adding code.

eon_llhead = LIST_HEAD_INITIALIZER(&eon_llhead);


>
> @@ -155,8 +156,7 @@
>  	if_attach(ifp);
>  	if_alloc_sadl(ifp);
>  	eonioctl(ifp, SIOCSIFADDR, (void *) ifp->if_addrlist.tqh_first);
> -	eon_llinfo.el_qhdr.link =
> -		eon_llinfo.el_qhdr.rlink = &(eon_llinfo.el_qhdr);
> +	LIST_INIT(&eon_llhead);

which means this diff can be nuked.