Subject: Re: [Fwd: Re: port-i386/36428: piixpcib boot hang on 4.0_BETA2]
To: Brett Lymn <blymn@baesystems.com.au>
From: doomwarrior <doomwarriorx@gmail.com>
List: tech-kern
Date: 07/02/2007 18:38:24
> Well, turn them into human readable labels so other people can
> understand what they are for.. something like:
>
>
>
I updated the patch.
Best Regards
Stephan
Index: piixpcib.c
===================================================================
RCS file: /pub/NetBSD-CVS/src/sys/arch/i386/pci/piixpcib.c,v
retrieving revision 1.10
diff -r1.10 piixpcib.c
65a66,73
> #define CPUID_PIII_REV_0x14_COPPERMINE 0x680
> #define CPUID_PIII_REV_0x0D_COPPERMINE 0x681
> #define CPUID_PIII_REV_0x0C_COPPERMINE 0x683
> #define CPUID_PIII_REV_0x07_COPPERMINE 0x686
> #define CPUID_PIII_REV_0x04_TULATATIN 0x6B0
> #define CPUID_PIII_REV_0x1C_TULATATIN 0x6B1
> #define CPUID_PIII_REV_0x01_TULATATIN 0x6B4
>
228a237,238
> aprint_debug("piixpcib: GSIC call EAX: 0x%x EBX: 0x%x ECX: 0x%x
EDX: 0x%x\n", regs.EAX, regs.EBX, regs.ECX, regs.EDX);
>
372,376c382,402
< /* setup some defaults */
< sc->sc_smi_cmd = 0xb2;
< sc->sc_smi_data = 0xb3;
< sc->sc_command = 0x47534982;
< sc->sc_flags = 0;
---
> struct cpu_info *ci = &cpu_info_primary;
>
> /* setup default values for supported processor types
or bail out */
> switch(ci->ci_signature) {
> case CPUID_PIII_REV_0x14_COPPERMINE:
> case CPUID_PIII_REV_0x0D_COPPERMINE:
> case CPUID_PIII_REV_0x0C_COPPERMINE:
> case CPUID_PIII_REV_0x07_COPPERMINE:
> case CPUID_PIII_REV_0x04_TULATATIN:
> case CPUID_PIII_REV_0x1C_TULATATIN:
> case CPUID_PIII_REV_0x01_TULATATIN:
> /* setup some defaults */
> sc->sc_smi_cmd = 0xb2;
> sc->sc_smi_data = 0xb3;
> sc->sc_command = 0x47534982;
> sc->sc_flags = 0;
> break;
> default:
> aprint_verbose("%s: SpeedStep SMI not
supported by processor\n", sc->sc_dev.dv_xname);
> return;
> }