Subject: Re: CVS commit: src/sys/sys
To: tech-kern@NetBSD.org, Mindaugas Rasiukevicius <rmind@netbsd.org>
From: Andrew Doran <ad@netbsd.org>
List: tech-kern
Date: 05/31/2007 12:46:10
On Thu, May 31, 2007 at 02:49:19PM +0400, Valeriy E. Ushakov wrote:

> [moved to tech-kern]
> 
> On Thu, May 31, 2007 at 09:52:30 +0100, Andrew Doran wrote:
> 
> > On Thu, May 31, 2007 at 05:39:24AM +0000, Mindaugas Rasiukevicius wrote:
> > 
> > > Modified Files:
> > > 	src/sys/sys: aio.h
> > > 
> > > Log Message:
> > > As suggested by <yamt>, make the aiocb structure alignment friendly.
> > > - Change the type of the internal members to int
> > > - Reorder the members
> > 
> > Thanks for doing this. You probably need to bump the major version of
> > librt and send a note to current-users, since the ABI has changed.
> 
> major bump will not help, as the structure in question is not a
> library interface, it's a kernel interface.  The only think library
> does - is passing the structure to the syscall.  Thus, syscall
> versioning is also required.

Ah, I forgot about that.

> Now, I wonder if all the churn can be justified for an unused
> (in-tree) library that existed in -current for less then a month.
> (SA syscalls removal was way more distruptive :))))
> 
> ISTR we have precedents of not doing "proper" versioning for things
> that appeared in -current and were changed before they appeared in any
> release, but I cannot recall the specifics.

A message to current-users would be good then.

Andrew