This is a multi-part message in MIME format.

--Multipart=_Mon__7_May_2007_02_18_39_+0300_eDz0_KKyQTClOi1d
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
> - i think members of struct aiocb should be ordered in an alignment
>   friendly manner.
> 
> - why _state is of char, rather than, say, int?

Mhm, not sure how friendly would that. Check the attached diff.

-- 
Best regards,
Mindaugas
www.NetBSD.org

--Multipart=_Mon__7_May_2007_02_18_39_+0300_eDz0_KKyQTClOi1d
Content-Type: text/plain;
 name="aio.h.diff"
Content-Disposition: attachment;
 filename="aio.h.diff"
Content-Transfer-Encoding: 7bit

Index: aio.h
===================================================================
RCS file: /cvsroot/src/sys/sys/aio.h,v
retrieving revision 1.2
diff -u -p -r1.2 aio.h
--- aio.h	3 May 2007 22:03:50 -0000	1.2
+++ aio.h	6 May 2007 23:12:05 -0000
@@ -47,16 +47,16 @@
  * Defined in the Base Definitions volume of IEEE Std 1003.1-2001 .
  */
 struct aiocb {
-	int aio_fildes;			/* File descriptor */
 	off_t aio_offset;		/* File offset */
 	volatile void *aio_buf;		/* I/O buffer in process space */
-	size_t aio_nbytes;		/* Length of transfer */
+	int aio_fildes;			/* File descriptor */
 	int aio_reqprio;		/* Request priority offset */
-	struct sigevent aio_sigevent;	/* Signal to deliver */
 	int aio_lio_opcode;		/* LIO opcode */
+	size_t aio_nbytes;		/* Length of transfer */
+	struct sigevent aio_sigevent;	/* Signal to deliver */
 
 	/* Internal kernel variables */
-	char _state;			/* State of the job */
+	int _state;			/* State of the job */
 	int _errno;			/* Error value */
 	ssize_t _retval;		/* Return value */
 };

--Multipart=_Mon__7_May_2007_02_18_39_+0300_eDz0_KKyQTClOi1d--