Subject: Re: USB stack needs early review (Re: Someone should fix our USB stack...)
To: None <tech-kern@NetBSD.org>
From: Nathan J. Williams <nathanw@wasabisystems.com>
List: tech-kern
Date: 04/26/2007 13:19:07
David Young <dyoung@pobox.com> writes:
> On Fri, Apr 27, 2007 at 12:48:33AM +0900, ITOH Yasufumi wrote:
>> - caddr_t removal, expecting it will soon be reverted :D
>
> It will not be reverted.
>
>> - volatiles in DMA structure, since it should not be needed
>> with proper bus_dmamap_sync(9)s
>
> Volatiles are needed on shared data structures, regardless of whether
> you use bus_dmamap_sync() properly.
Are you talking about data structures shared between the kernel top
half and bottom half? If so, I think I know what you're saying here,
but I'd like to say that I consider this use of volatile, while
expedient, to be a problematic workaround for a deficient spl()
implementation.
- Nathan